Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Separate Foundation Palette #9683

Closed
wants to merge 20 commits into from
Closed

[WIP] Separate Foundation Palette #9683

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9448cb8
Separate the Foundation palette into a map of colors, and a map to as…
natewiebe13 Jan 20, 2017
a02118a
Show missing key in error message
natewiebe13 Jan 20, 2017
f7287fe
Correct color name typo
natewiebe13 Jan 20, 2017
2f0649a
Update error message wording to be consistent
natewiebe13 Jan 20, 2017
085311c
Revert settings file as this is automatically generated
natewiebe13 Jan 20, 2017
cfecb79
Move color map to the color utility file
natewiebe13 Jan 20, 2017
610d044
Use the safe method of getting a map value
natewiebe13 Jan 20, 2017
2a95a9a
Revert unrelated CSS changesg
natewiebe13 Jan 20, 2017
5132096
Remove unneeded checks
natewiebe13 Jan 20, 2017
ca7ba75
Update message about avoiding direct color usage in components
natewiebe13 Jan 20, 2017
7ffb49e
Import needed files for color unit test
natewiebe13 Jan 20, 2017
84f61b0
Update comment for how the color map should be used
natewiebe13 Jan 20, 2017
2fec363
Add unit tests for get-color and get-state
natewiebe13 Jan 20, 2017
b83f720
Modify the unit tests to be more flexible
natewiebe13 Jan 20, 2017
cf22604
Change unit test to not rely on other functions
natewiebe13 Jan 20, 2017
91e547c
Rename `get-state()` to `get-state-color()` for clarity
natewiebe13 Jan 24, 2017
018e1ab
Require declaring the color in the colors map when using states
natewiebe13 Jan 24, 2017
7d72d2e
Make `get-color()` backwards compatible and add a deprecation warning
natewiebe13 Jan 31, 2017
e3cd682
Add component variables for states
natewiebe13 Apr 20, 2017
970b67d
Merge branch 'v6.4' into color-palette-changes
natewiebe13 Apr 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scss/util/_color.scss
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@

@import 'math';

/// Colors available by using `get-color()`.
/// Colors available by using `get-color()`. These should not be used directly within components, variables should be used instead to make components customizable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get-state() and settings should be used instead to make components customizable.

/// @type Map
$foundation-colors: (
'blue': #1779ba,
Expand Down