Support for cheerio options

[dherges]

Right now, releaseTheKraken() replaces " with " (and other entties as well).

Issue 1: componentFactory should use elem.html() instead of $.html(elem)

Issue 2: it should be possible to pass cherio options to the inky() function --> already done on master

[ibarral]

Hello,

Do you have an example to pass cherio options to the inky() function? I can't make it work.

Thanks!

[dherges]

Yes, use it like this with gulp/vinyl (inky from the master branch):

vfs.src('somefile.html')
  .pipe(inky({cheerio: {decodeEntities: false}}))
  .pipe(vfs.dest('output'))

somefile.html:

"mytext"

output:

"mytext"

So, the options are actually passed to cheerio.load(input, opts), but entities (") go missing in the final output (after releaseTheKraken().html() ... guess that happens in componentFactory.js

[dherges]

I was able to drill down the issue

this input results in decoded entities for the text "broken" .. output "broken"" despite passing {decodeEntities: false}. "works" is outputted as "works" (since its outside the <center> tag ?).

<table class="body">
  <tr>
    <td class="center" align="center" valign="top">
      <center>
"broken"
      </center>
"works"
    </td>
  </tr>
</table>

putting an attribute data-parsed on the <center> tag works for both texts. inside and outside the center tag, output is "works"

<table class="body">
  <tr>
    <td class="center" align="center" valign="top">
      <center data-parsed>
"works"
      </center>
"works"
    </td>
  </tr>
</table>

[ibarral]

Thanks for the update!

But I have a doub't: I have installed Inky using NPM (https://www.npmjs.com/package/inky).

I'm using Gulp to compile the files, and if I pass the cheerio options to Inky, for example:

.pipe(inky({cheerio: {decodeEntities: false}}))

It won't work.

This feature works ok from the NPM version?

Thanks!

[dherges]

No, the feature was introduced here 9fda83e#diff-168726dbe96b3ce427e7fedce31bb0bc and is included in the master branch ...

try npm install github:zurb/inky#master to get it

[ibarral]

Ok, thanks for your help! :)

[rafibomb]

@dherges @ibarral Just published the Foundation for Emails 2.1 release blog post and the release went out this morning! We also started a discussion on the future of Inky and what amazing integrations can be made. I'm sure you have some comments, questions, or ideas: http://foundation.zurb.com/forum/posts/39717-architecting-the-future-of-foundation-for-emails