Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Stop using most actions-rs actions. #108

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

waywardmonkeys
Copy link
Contributor

This leaves a usage of their grcov. The actions from this organization aren't maintained and result in warnings within the GitHub Actions UI.

This leaves a usage of their `grcov`. The actions from this
organization aren't maintained and result in warnings within
the GitHub Actions UI.
@waywardmonkeys
Copy link
Contributor Author

One difference is that the matchers in this toolchain action won't annotate the PR with warnings from clippy, etc.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.69% 🎉

Comparison is base (966faaf) 79.33% compared to head (140f3bb) 80.02%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   79.33%   80.02%   +0.69%     
==========================================
  Files          27       27              
  Lines        5217     5217              
==========================================
+ Hits         4139     4175      +36     
+ Misses       1078     1042      -36     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PierreZ
Copy link
Member

PierreZ commented Aug 31, 2023

Where do you see it is unmaintained?

@waywardmonkeys
Copy link
Contributor Author

This is a good start: actions-rs/toolchain#216

The actions-rs actions are using deprecated functionality within GitHub Actions that is planned to go away. For examples of that, scroll down on the right panel in https://github.com/foundationdb-rs/foundationdb-rs/actions/runs/6038305182 and everything about set-output and node12.

@PierreZ PierreZ merged commit 23f4b58 into foundationdb-rs:main Sep 4, 2023
29 checks passed
@PierreZ
Copy link
Member

PierreZ commented Sep 4, 2023

Perfect, thanks for the links and the contribution 🎉

@waywardmonkeys waywardmonkeys deleted the update-actions branch October 5, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants