Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix std::slice::from_raw_parts usage from Nightly #122

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

PierreZ
Copy link
Member

@PierreZ PierreZ commented Feb 12, 2024

Fix #121

@PierreZ PierreZ added the correctness run hundred of iterations on the bindingTester during CI label Feb 12, 2024
@PierreZ PierreZ force-pushed the fix/from_raw_parts branch 3 times, most recently from c693edc to 4d52332 Compare February 12, 2024 13:12
@PierreZ PierreZ changed the title test Fix std::slice::from_raw_parts usage from Nightly Feb 12, 2024
@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 7892530961

Details

  • -7 of 23 (69.57%) changed or added relevant lines in 4 files are covered.
  • 27 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.4%) to 74.017%

Changes Missing Coverage Covered Lines Changed/Added Lines %
foundationdb/src/mapped_key_values.rs 5 12 41.67%
Files with Coverage Reduction New Missed Lines %
foundationdb/src/directory/directory_layer.rs 2 94.68%
foundationdb/src/mapped_key_values.rs 2 45.87%
foundationdb/src/directory/mod.rs 3 92.56%
foundationdb-bindingtester/src/main.rs 5 87.9%
foundationdb/src/directory/directory_partition.rs 15 77.42%
Totals Coverage Status
Change from base Build 7633321970: -0.4%
Covered Lines: 4199
Relevant Lines: 5673

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c3f92dc) 82.86% compared to head (c690dd6) 82.27%.
Report is 1 commits behind head on main.

Files Patch % Lines
foundationdb/src/mapped_key_values.rs 41.66% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   82.86%   82.27%   -0.60%     
==========================================
  Files          23       23              
  Lines        4914     4919       +5     
==========================================
- Hits         4072     4047      -25     
- Misses        842      872      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PierreZ PierreZ marked this pull request as ready for review February 12, 2024 14:22
@PierreZ PierreZ force-pushed the fix/from_raw_parts branch 7 times, most recently from 5faa747 to a96a5e4 Compare February 13, 2024 20:34
@PierreZ PierreZ merged commit 22da934 into foundationdb-rs:main Feb 14, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctness run hundred of iterations on the bindingTester during CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix from_raw_parts usage from nightly
3 participants