Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 7.3 in simulation #123

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Conversation

PierreZ
Copy link
Member

@PierreZ PierreZ commented Feb 28, 2024

Close #115 with the help of @Wonshtrum

@coveralls
Copy link

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8265215983

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.4%) to 74.547%

Files with Coverage Reduction New Missed Lines %
foundationdb/src/directory/mod.rs 1 93.39%
foundationdb/src/directory/directory_partition.rs 7 79.03%
foundationdb/src/directory/directory_layer.rs 11 92.34%
Totals Coverage Status
Change from base Build 8261424759: 0.4%
Covered Lines: 4358
Relevant Lines: 5846

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (9d7488d) to head (383469e).
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   83.98%   84.00%   +0.02%     
==========================================
  Files          23       23              
  Lines        5001     5001              
==========================================
+ Hits         4200     4201       +1     
+ Misses        801      800       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PierreZ PierreZ force-pushed the dev/pz/simulation_73 branch 5 times, most recently from 1303bc1 to 2804ba9 Compare February 28, 2024 15:15
@PierreZ PierreZ marked this pull request as ready for review March 13, 2024 13:22
@PierreZ PierreZ merged commit f7ca165 into foundationdb-rs:main Mar 13, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for 7.3
4 participants