Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 7.0.0 #48

Merged
merged 13 commits into from
May 3, 2022
Merged

Support for 7.0.0 #48

merged 13 commits into from
May 3, 2022

Conversation

PierreZ
Copy link
Member

@PierreZ PierreZ commented Apr 25, 2022

Will fix #17

@PierreZ PierreZ force-pushed the feat/7.0.0 branch 3 times, most recently from 9ceec03 to 0c0f190 Compare April 26, 2022 12:46
@PierreZ PierreZ added the correctness run hundred of iterations on the bindingTester during CI label Apr 26, 2022
@PierreZ PierreZ force-pushed the feat/7.0.0 branch 3 times, most recently from bbe077e to cad20be Compare April 26, 2022 15:00
@PierreZ PierreZ force-pushed the feat/7.0.0 branch 2 times, most recently from 4ac13fa to 9d41a9e Compare April 26, 2022 15:55
@coveralls
Copy link

coveralls commented Apr 27, 2022

Pull Request Test Coverage Report for Build 2256305493

  • 69 of 95 (72.63%) changed or added relevant lines in 3 files are covered.
  • 24 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.8%) to 74.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
foundationdb/src/future.rs 37 63 58.73%
Files with Coverage Reduction New Missed Lines %
foundationdb-bindingtester/src/main.rs 1 89.69%
foundationdb/src/directory/mod.rs 1 93.38%
foundationdb/src/directory/directory_subspace.rs 4 91.78%
foundationdb/src/directory/directory_partition.rs 6 76.87%
foundationdb/src/directory/directory_layer.rs 12 91.48%
Totals Coverage Status
Change from base Build 2231211423: -0.8%
Covered Lines: 4147
Relevant Lines: 5534

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #48 (ada79e4) into main (ef9993e) will decrease coverage by 0.36%.
The diff coverage is 72.63%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   83.67%   83.30%   -0.37%     
==========================================
  Files          24       24              
  Lines        4716     4798      +82     
==========================================
+ Hits         3946     3997      +51     
- Misses        770      801      +31     
Impacted Files Coverage Δ
foundationdb-gen/src/lib.rs 0.44% <ø> (ø)
foundationdb/src/database.rs 86.95% <ø> (+1.08%) ⬆️
foundationdb/src/future.rs 74.89% <58.73%> (-5.54%) ⬇️
foundationdb-bindingtester/src/main.rs 89.69% <100.00%> (+<0.01%) ⬆️
foundationdb/src/transaction.rs 88.96% <100.00%> (+0.33%) ⬆️
foundationdb/src/directory/directory_layer.rs 91.48% <0.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9993e...ada79e4. Read the comment docs.

@PierreZ PierreZ marked this pull request as ready for review April 28, 2022 13:12
@PierreZ PierreZ merged commit 3410243 into foundationdb-rs:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctness run hundred of iterations on the bindingTester during CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge support for release-7.0
4 participants