Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more useful version of get_mapped_ranges #68

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

PierreZ
Copy link
Member

@PierreZ PierreZ commented Sep 5, 2022

No description provided.

@coveralls
Copy link

coveralls commented Sep 5, 2022

Pull Request Test Coverage Report for Build 3007332019

  • 13 of 17 (76.47%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 74.623%

Changes Missing Coverage Covered Lines Changed/Added Lines %
foundationdb/src/transaction.rs 13 17 76.47%
Files with Coverage Reduction New Missed Lines %
foundationdb/src/directory/mod.rs 1 94.85%
foundationdb/src/directory/directory_partition.rs 6 84.33%
foundationdb/src/directory/directory_layer.rs 9 91.68%
Totals Coverage Status
Change from base Build 2977354854: 0.02%
Covered Lines: 4258
Relevant Lines: 5706

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #68 (7fc2442) into main (ef379b3) will decrease coverage by 0.00%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   82.82%   82.82%   -0.01%     
==========================================
  Files          26       26              
  Lines        4937     4954      +17     
==========================================
+ Hits         4089     4103      +14     
- Misses        848      851       +3     
Impacted Files Coverage Δ
foundationdb/src/transaction.rs 89.35% <76.47%> (-0.65%) ⬇️
foundationdb/src/directory/directory_layer.rs 91.68% <0.00%> (-1.42%) ⬇️
foundationdb/src/directory/mod.rs 94.85% <0.00%> (ø)
foundationdb/src/tuple/pack.rs 92.73% <0.00%> (+0.18%) ⬆️
foundationdb/src/mapped_key_values.rs 44.03% <0.00%> (+2.75%) ⬆️
foundationdb/src/directory/directory_partition.rs 84.32% <0.00%> (+2.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PierreZ PierreZ force-pushed the get_flat_map branch 3 times, most recently from 5625c6b to 7fc2442 Compare September 5, 2022 20:24
@PierreZ PierreZ marked this pull request as ready for review September 5, 2022 20:25
@PierreZ PierreZ merged commit 51af452 into foundationdb-rs:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants