Tenants

[PierreZ]

Adding support for tenants.

[PierreZ]

Blocked by #31 because Tenant management functions are expected to run inside a db.run

[coveralls]

Pull Request Test Coverage Report for Build 3867971507

• 62 of 185 (33.51%) changed or added relevant lines in 5 files are covered.
• 50 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-1.4%) to 72.541%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
foundationdb/src/error.rs	0	3	0.0%
foundationdb-bindingtester/src/main.rs	12	58	20.69%
foundationdb/src/tenant.rs	38	112	33.93%

Files with Coverage Reduction	New Missed Lines	%
foundationdb-bindingtester/src/main.rs	1	86.58%
foundationdb/src/directory/directory_subspace.rs	2	90.67%
foundationdb/src/directory/directory_layer.rs	8	92.46%
foundationdb/src/transaction.rs	8	87.27%
foundationdb/src/database.rs	31	69.01%

Totals
Change from base Build 3669323292:	-1.4%
Covered Lines:	4343
Relevant Lines:	5987

---

💛 - Coveralls

[codecov-commenter]

Codecov Report

Base: 82.44% // Head: 79.92% // Decreases project coverage by -2.52% ⚠️

Coverage data is based on head (378753b) compared to base (a77116e).
Patch coverage: 33.51% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   82.44%   79.92%   -2.53%     
==========================================
  Files          26       27       +1     
  Lines        5042     5235     +193     
==========================================
+ Hits         4157     4184      +27     
- Misses        885     1051     +166     

Impacted Files	Coverage Δ
foundationdb/src/error.rs	60.56% <0.00%> (-2.68%)	⬇️
foundationdb/src/lib.rs	100.00% <ø> (ø)
foundationdb/src/tuple/hca.rs	67.25% <ø> (-0.29%)	⬇️
foundationdb-bindingtester/src/main.rs	86.58% <20.68%> (-3.16%)	⬇️
foundationdb/src/tenant.rs	33.92% <33.92%> (ø)
foundationdb/src/database.rs	69.01% <100.00%> (-17.99%)	⬇️
foundationdb/src/directory/mod.rs	94.11% <100.00%> (+0.73%)	⬆️
foundationdb/src/directory/directory_layer.rs	92.46% <0.00%> (-1.88%)	⬇️
foundationdb/src/directory/directory_subspace.rs	90.66% <0.00%> (-1.34%)	⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Speedy37]

Good start.
I think a TenantDatabase type with create_trx, run and transact* methods could be nice.

[PierreZ]

Good start. I think a TenantDatabase type with create_trx, run and transact* methods could be nice.

I agree 😄 Currently focusing on the bindingTester, but that should be next 🚀

[PierreZ]

I have started some work with another pr because I think something is wrong on bindingTester.

[PierreZ]

Blocked by bindingTester issue. More details here

[PierreZ]

Given tenant are highly experimental and won't be stable in a short-term, I propose that:

• we add more warning about the state of tenants in fdb,
• we allow failure on bindingTester when running it with tenant enabled.

Like this, we will be able to merge this work.

In the mean time, I'm trying to get access to bigger machine for Github Actions

[Speedy37]

Maybe put it behind a feature flag.

[PierreZ]

Maybe put it behind a feature flag.

Sorry for the late reply, i was busy on other subject. You are right, I will do that, once I'm back from holiday 🎄

[PierreZ]

Ready to be reviewed.

We have used the tenant's feature internally in Clever Cloud, so things are working as expected.

Please bare in mind that this is an experimental feature