Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add week 2 "Real world fetch" workshop #65

Merged
merged 2 commits into from Feb 21, 2020
Merged

Conversation

oliverjam
Copy link
Contributor

@oliverjam oliverjam commented Feb 17, 2020

https://github.com/oliverjam/real-world-fetch

  • Covers stuff you need to use fetch in a real app
    • Error handling for non-200 HTTP responses
    • fetch options:
      • method
      • body
  • Handling user input with forms
    • preventDefault()
    • Various ways to access form input data

I'm not sure if it needs a proper "workshop" bit at the end. Some of the interspersed "challenges" are more involved and are basically what I'd want from a "workshop" anyway.

I also swapped the first-class functions and learn-fetch-promises workshops around, since we should cover callbacks before promises.

Closes #35

Should teach functions/callbacks before covering fetch/promises
@oliverjam oliverjam changed the title Add week 2 "Real forld fetch" workshop Add week 2 "Real world fetch" workshop Feb 18, 2020
@bobbysebolao
Copy link
Contributor

I ran through this and I think it's really good. I think you're right that the challenges throughout are involved enough to make this feel like a workshop with enough chances for students to practice the concepts that are covered for themselves 👍

Copy link
Contributor

@Albadylic Albadylic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is a great resource. I think the challenges are at a good level that we don't need to add a workshop section.

I only have one edit to suggest which is a pedantic one again 🤓 . If you Ctrl + F in the readme "and use", I think these words can be removed.

@Albadylic
Copy link
Contributor

p.s. I definitely learnt a couple of things from reading this!

@oliverjam
Copy link
Contributor Author

@Albadylic cheers, fixed that bit. I think it could still do with a "workshop" part at the end because this is supposed to fill 2 hours. It's currently a 5 or 6 minute read (obviously longer with all the breaks to do the code challenges/let stuff sink in). It would be nice for people who have done some fetch before and whizz through the simpler parts to be able to push themselves a bit.

@Albadylic
Copy link
Contributor

@oliverjam Yeah, I reckon this would benefit from a workshop section to fill the two hours. It could be very similar to the challenges, as in the learn-fetch workshop, but on a new api - something that is likely to 404.

@oliverjam
Copy link
Contributor Author

@Albadylic I've added a simple-ish workshop at the end using the same PokéAPI they used in the first fetch workshop. This time they actually have to make a form and render to the page, plus handle errors.

@Albadylic
Copy link
Contributor

Anytime you use the PokeAPI, you get my automatic approval.

@oliverjam oliverjam merged commit e8db040 into master Feb 21, 2020
@oliverjam oliverjam deleted the week-2-real-world-fetch branch February 21, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submitting data with fetch
3 participants