New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add week 2 "Real world fetch" workshop #65
Conversation
Should teach functions/callbacks before covering fetch/promises
I ran through this and I think it's really good. I think you're right that the challenges throughout are involved enough to make this feel like a workshop with enough chances for students to practice the concepts that are covered for themselves 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is a great resource. I think the challenges are at a good level that we don't need to add a workshop section.
I only have one edit to suggest which is a pedantic one again 🤓 . If you Ctrl + F in the readme "and use", I think these words can be removed.
p.s. I definitely learnt a couple of things from reading this! |
@Albadylic cheers, fixed that bit. I think it could still do with a "workshop" part at the end because this is supposed to fill 2 hours. It's currently a 5 or 6 minute read (obviously longer with all the breaks to do the code challenges/let stuff sink in). It would be nice for people who have done some fetch before and whizz through the simpler parts to be able to push themselves a bit. |
@oliverjam Yeah, I reckon this would benefit from a workshop section to fill the two hours. It could be very similar to the challenges, as in the learn-fetch workshop, but on a new api - something that is likely to 404. |
@Albadylic I've added a simple-ish workshop at the end using the same PokéAPI they used in the first fetch workshop. This time they actually have to make a form and render to the page, plus handle errors. |
Anytime you use the PokeAPI, you get my automatic approval. |
https://github.com/oliverjam/real-world-fetch
fetch
in a real appfetch
options:preventDefault()
I'm not sure if it needs a proper "workshop" bit at the end. Some of the interspersed "challenges" are more involved and are basically what I'd want from a "workshop" anyway.
I also swapped the first-class functions and learn-fetch-promises workshops around, since we should cover callbacks before promises.
Closes #35