Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add profiling option, using code woven module timer #212

Open
naturallymitchell opened this issue Oct 27, 2018 · 7 comments
Open

add profiling option, using code woven module timer #212

naturallymitchell opened this issue Oct 27, 2018 · 7 comments

Comments

@naturallymitchell
Copy link
Member

#27

image

@Arnaz87
Copy link
Contributor

Arnaz87 commented Oct 27, 2018

what about when the logs are separated by potentially hours?

@naturallymitchell
Copy link
Member Author

that's not at all what's going on in that screenshot

@Arnaz87
Copy link
Contributor

Arnaz87 commented Oct 27, 2018

I know, it's a case the screenshot doesn't cover, I want to know what should we do if that happens? It can happen for sure, should we log hundreds of thousands of milliseconds or log the hour it happens?

@naturallymitchell
Copy link
Member Author

timeago.js already answered that

@naturallymitchell naturallymitchell transferred this issue from jazzdotdev/log Jan 13, 2019
@naturallymitchell naturallymitchell changed the title Time between function calls add profiling option, using code woven module timer Jan 13, 2019
@naturallymitchell
Copy link
Member Author

will degrade speed, so needs to be optional
need to read from the end to find if there's a return in the last line, and if so put the _log.time()(??) before it
can any fs function do this? https://users.rust-lang.org/t/idiomatic-way-of-reading-a-text-file-line-by-line-in-reverse/8547
would a streaming reader make more sense?
once we have the last line number or the line number of the return, can we edit it at that line without reading line by line?
https://www.reddit.com/r/rust/comments/2pijdj/accessing_file_name_function_name_and_line_number/
https://doc.rust-lang.org/std/io/struct.LineWriter.html

#207 #208 #210 #211

@naturallymitchell
Copy link
Member Author

also, I definitely want to start the timer outside of the module
if we have to modify it from the head, then every line number gets off from source
the last line is fine to change

@naturallymitchell
Copy link
Member Author

move to jazzdotdev/jazz-libs#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants