Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ethers-core dependency #8

Closed
Evalir opened this issue Oct 25, 2023 · 1 comment · Fixed by #14
Closed

Remove ethers-core dependency #8

Evalir opened this issue Oct 25, 2023 · 1 comment · Fixed by #14

Comments

@Evalir
Copy link
Member

Evalir commented Oct 25, 2023

Right now we're coupled to ethers due to using RawAbi, and the Chain enum. This means we need to keep patches on foundry to keep ethers versions in sync. We should remove the dep as follows:

  • Integrate alloy-rs/chains when ready
  • Move RawAbi into block-explorers, as it's not an alloy-related type nor an RPC type. It just uses some metadata from the ABI for verification purposes.
@Evalir Evalir mentioned this issue Oct 25, 2023
Open
43 tasks
@DaniPopes
Copy link
Member

RawAbi is not necessary anymore: #10

@DaniPopes DaniPopes mentioned this issue Nov 14, 2023
Merged
DaniPopes added a commit that referenced this issue Nov 15, 2023
@DaniPopes
feat: remove Ethers (#14)
f3d9ca4 
Closes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove Ethers foundry-rs/block-explorers
2 participants
@Evalir @DaniPopes