refactor: extra files logic #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Mar 11, 2024
|
thank you! curious if this also resolves the issue in this comment: foundry-rs/foundry#6241 (comment) happy to open a new issue if not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves foundry-rs/foundry#6241
Removes
write_extralogic fromArtifactOutputtraitAdds new methods:
handle_artifacts- by default empty implementation which can be overloaded to implement handling of compiled artifacts.ConfigurableArtifactsimplements it to write extra filesis_dirty- method allowingArtifactOutputimplementations to reject cached artifacts and enforce recompilation. Used byConfigurableArtifactsto reject artifacts which data is not enough to write required extra output files.handle_cached_artifacts- same ashandle_artifactsbut for those which were not recompiled. Used byConfigurableArtifactsto write extra files from cached artifacts.