Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: camelCase for exitCode #458

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

PaulRBerg
Copy link
Contributor

Pardon my OCD but I am getting a Solhint warning in my copy of Vm (in PRBTest) because of exit_code:

warning Variable name must be in mixedCase var-name-mixedcase

@mds1
Copy link
Collaborator

mds1 commented Sep 27, 2023

Ah, should have caught this when it was originally merged. This is technically a breaking change since it's already in a release, but the release was recent and from a sourcegraph query it seems vulcan are the only users (clearly that search isn't perfect since PRBTest isn't there).

Given that, we can sneak this into a v1.7.0 once @vdrg and @gnkz from vulcan acknowledge

@vdrg
Copy link
Contributor

vdrg commented Sep 27, 2023

@mds1 Thanks for letting us know! Acknowledged, we'll update forge-std once this is merged.

@mds1
Copy link
Collaborator

mds1 commented Sep 27, 2023

Great, planning to merge+release early next week since I'm out this week—will keep you updated :)

@PaulRBerg
Copy link
Contributor Author

Also happy to update PRBTest to include the fix. I don't mind the breaking change since I've only added exit_code this week.

@mds1 mds1 merged commit 4d9985c into foundry-rs:master Sep 29, 2023
3 checks passed
@PaulRBerg PaulRBerg deleted the chore/camel-case branch October 2, 2023 10:09
gnkz added a commit to nomoixyz/vulcan that referenced this pull request Oct 8, 2023
This is a breaking change because v.1.7.0 introduced a breaking change.

Details here foundry-rs/forge-std#458
gnkz added a commit to nomoixyz/vulcan that referenced this pull request Oct 8, 2023
* chore!: update forge-std to v1.7.1

This is a breaking change because v.1.7.0 introduced a breaking change.

Details here foundry-rs/forge-std#458

* chore: remove ad-hoc SerializeJson interface

* chore: update functions mutability
gnkz added a commit to nomoixyz/vulcan that referenced this pull request Oct 8, 2023
* chore!: update forge-std to v1.7.1

This is a breaking change because v.1.7.0 introduced a breaking change.

Details here foundry-rs/forge-std#458

* chore: remove ad-hoc SerializeJson interface

* chore: update functions mutability
gnkz added a commit to nomoixyz/vulcan that referenced this pull request Oct 10, 2023
* chore!: update forge-std to v1.7.1

This is a breaking change because v.1.7.0 introduced a breaking change.

Details here foundry-rs/forge-std#458

* chore: remove ad-hoc SerializeJson interface

* chore: update functions mutability
gnkz added a commit to nomoixyz/vulcan that referenced this pull request Oct 10, 2023
* docs: add examples to some modules

* Update forge-std (#214)

* chore!: update forge-std to v1.7.1

This is a breaking change because v.1.7.0 introduced a breaking change.

Details here foundry-rs/forge-std#458

* chore: remove ad-hoc SerializeJson interface

* chore: update functions mutability

* docs: add examples for all modules

* style: format

* docs: update installation instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants