feat: Add support for polygon amoy testnet #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Apr 17, 2024
src/StdChains.sol
Outdated
Comment on lines
216
to
218
| setChainWithDefaultRpcUrl( | ||
| "polygon_mumbai", ChainData("Polygon Mumbai", 80001, "https://rpc-mumbai.maticvigil.com") | ||
| ); |
There was a problem hiding this comment.
Should we remove mumbai, or is it not fully shut down yet and we should keep it for now?
There was a problem hiding this comment.
Per https://polygon.technology/blog/introducing-the-amoy-testnet-for-polygon-pos I've removed Mumbai:
No Goerli = broken Mumbai. The community consensus across the Polygon ecosystem has been to deprecate Mumbai in tandem with Goerli.
mds1
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Polygon is deprecating Mumbai testnet and preferring the new testnet, Amoy. We are adding supports for Amoy accordingly in the implementation and test file.
Reference: