Update .gitignore preventing .env push
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably it won't happen because as far as I know, foundry does not support it, but devs could use this template in connection with other tools like `hardhat` that use `.env` and it's not a bad practice to prevent this file to be pushed to the repo. It could be useful to add more files/folder to `.gitignore`, it would not hurt to ban things like `node_modules` and similar
|
Yeah, I wholeheartedly agree with @StErMi:
|
|
the .env is already in .gitignore file, should we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably it won't happen because as far as I know, foundry does not support it, but devs could use this template in connection with other tools like
hardhatthat use.envand it's not a bad practice to prevent this file to be pushed to the repo.It could be useful to add more files/folder to
.gitignore, it would not hurt to ban things likenode_modulesand similar