Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix branding color #17

Closed
wants to merge 1 commit into from
Closed

Fix branding color #17

wants to merge 1 commit into from

Conversation

PaulRBerg
Copy link
Contributor

As mentioned in the branding.color docs, black is not an option.

I have changed it to gray-dark, which seems to be the closest to black.

gakonst
gakonst approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just got merge conflict due to that other PR

@PaulRBerg
Copy link
Contributor Author

Thanks for accepting this PR - though we can close this because #19 included the fix for the branding color.

@PaulRBerg PaulRBerg closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PaulRBerg @gakonst