Critical fix: load home path with os.homedir
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: define "PLATFORM" once in the global scope
gakonst
approved these changes
Jan 17, 2023
PaulRBerg
added a commit
to PaulRBerg/foundry-toolchain
that referenced
this pull request
Jan 26, 2023
refactor: define "PLATFORM" once in the global scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported by @mds1 and @davidlaprade here:
gitcoinco/Alpha-Governor-Upgrade#12
I'm sorry guys, I messed up the cache implementation. It looks like the tilde symbol
~is not available in Node.js.I had to use
os.homedir()instead of~/. Proof that this works now:https://github.com/PaulRBerg/foundry-template/actions/caches
I ran the new implementation in my foundry-template a few dozen times to make sure that it works properly now. See a few screenshots below.
On the bright side, this issue didn't cause any trouble to end users. It just didn't do the caching, that's all - it didn't save any bogus cache.