Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross platform test seem to hang mostly on apple aarch64 job #1984

Closed
2 tasks
mattsse opened this issue Jun 15, 2022 · 4 comments · Fixed by #2075
Closed
2 tasks

cross platform test seem to hang mostly on apple aarch64 job #1984

mattsse opened this issue Jun 15, 2022 · 4 comments · Fixed by #2075
Assignees
Labels
T-bug Type: bug T-meta Type: meta

Comments

@mattsse
Copy link
Member

mattsse commented Jun 15, 2022

Component

Forge, Anvil

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

No response

Describe the bug

the aarch64 apple cross platform test seems to hang regularly at this test,

https://github.com/foundry-rs/foundry/runs/6903774179?check_suite_focus=true

but sometimes others

https://github.com/foundry-rs/foundry/runs/6905730226?check_suite_focus=true

test cmd::can_emit_multiple_extra_output has been running for over 60 seconds
test script::can_deploy_100_txes_concurrently has been running for over 60 seconds
test script::can_deploy_broadcast_wrap has been running for over 60 seconds

test cmd::can_emit_multiple_extra_output has been running for over 60 seconds
test script::can_deploy_100_txes_concurrently has been running for over 60 seconds
test script::can_deploy_broadcast_wrap has been running for over 60 seconds
test script::can_deploy_100_txes_concurrently ... ok
test script::can_deploy_mixed_broadcast_modes has been running for over 60 seconds
test script::can_deploy_broadcast_wrap ... ok
test cmd::can_emit_multiple_extra_output ... ok
test script::can_deploy_no_arg_broadcast has been running for over 60 seconds
test script::can_deploy_script_with_lib has been running for over 60 seconds

looks like this might be related to deploy/script tests so perhaps an anvil issue

@mattsse mattsse added the T-bug Type: bug label Jun 15, 2022
@onbjerg onbjerg added the T-meta Type: meta label Jun 18, 2022
@onbjerg
Copy link
Member

onbjerg commented Jun 21, 2022

I think this is because we're compiling with the local profile which is a lot slower than the default profile Cargo uses for tests (see #2041)

@onbjerg onbjerg self-assigned this Jun 21, 2022
@onbjerg
Copy link
Member

onbjerg commented Jun 22, 2022

Ah, I think I have an idea why this job specifically is still slow - we're cross compiling from x86 so I'm pretty sure all of these tests are being run under emulation lol

@mattsse
Copy link
Member Author

mattsse commented Jun 22, 2022

rekt

I guess since we already run the test on apple, perhaps it's fine to just compile cargo check?

@onbjerg
Copy link
Member

onbjerg commented Jun 22, 2022

Yeah I think that's fine, cross-platform we mostly test for platform behavior anyway like paths etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug T-meta Type: meta
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants