ci: re-enable windows #2041
Merged
ci: re-enable windows #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
onbjerg/windows
branch
2 times, most recently
from
bc8ea4d
to
029e3ba
Compare
|
So, the release workflow seems to work fine and complete in an OK amount of time (~15 mins which is in line with other platforms), but the cross-platform tests take forever to run (~1 hr). Searching around it seems like this is primarily just because GitHub's hosted runners for Windows are severely underpowered :/ Edit: Proof of release https://github.com/foundry-rs/foundry/runs/6977465668?check_suite_focus=true |
onbjerg
force-pushed
the
onbjerg/windows
branch
2 times, most recently
from
88b076b
to
a08a0cf
Compare
|
Okay so not running with |
2 tasks
mattsse
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We originally disabled Windows cross-platform builds and releases because we ran out of memory for some reason. Building from source for Windows might be a non-starter for some (experience/effort/resource constraints) so we should investigate re-adding Windows support.
Solution
Re-enable Windows and figure out if it works/why it didn't before. Also fix any cross-platform tests that fail on Windows
Closes #773 and #2021