Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More helpful output on test failure #2544

Closed
2 tasks done
ehildenb opened this issue Aug 1, 2022 · 2 comments
Closed
2 tasks done

More helpful output on test failure #2544

ehildenb opened this issue Aug 1, 2022 · 2 comments
Assignees
Labels
C-forge Command: forge Cmd-forge-test Command: forge test T-bug Type: bug

Comments

@ehildenb
Copy link

ehildenb commented Aug 1, 2022

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (9ed1c37 2022-08-01T00:07:48.156201922Z)

What command(s) is the bug in?

forge test

Operating System

Linux

Describe the bug

I am writing some tests that use forking capabilities of Foundry.

My forking capability tests are broken, they aren't doing the right thing, and cause Foundry to panic.

Screenshot from 2022-08-01 11-25-45

However, the last output before panicking is talking about my Prank tests, not about my Fork tests. But deleting the file ForkTest.t.sol causes the tests to be fine, so the problem is there (in the fork tests).

Can the output be made more helpful on panic? Maybe to say which test it's panicking on?

Attached is a zip directory this is happening in:

foundry.zip

@ehildenb ehildenb added the T-bug Type: bug label Aug 1, 2022
@onbjerg onbjerg added Cmd-forge-test Command: forge test C-forge Command: forge labels Aug 1, 2022
@onbjerg onbjerg added this to the v1.0.0 milestone Aug 1, 2022
@onbjerg
Copy link
Member

onbjerg commented Aug 11, 2022

For now we'll try to improve the error messages, but we should also explore if we can avoid panicking by extending REVM's Database trait

@onbjerg onbjerg removed this from the v1.0.0 milestone Aug 23, 2022
@onbjerg
Copy link
Member

onbjerg commented Sep 8, 2022

This should now be handled more gracefully

@onbjerg onbjerg closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-test Command: forge test T-bug Type: bug
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants