-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forge create
and forge script
not working with --ledger
#6516
Comments
I just ran into the same issue after doing I can confirm that it works with that version but not with the latest on in 0.2.0 /cc'ing @Evalir has we've been discussing this issue offline. |
Same issue here—reverting to the suggested commit here worked for me. |
Same issue |
Any updates on this issue? cc @gakonst |
an update on my end, I was able to run This is quite annoying though as I need to deploy and verify contracts on arbitrum-sepolia and I can't verify with the older build and can't deploy from a ledger with the newer build. |
Also facing this, on latest nightly on a script with 3 txns, foundry asked me to sign the first and then it just stopped. |
I'd appreciate a minimal repro for this. |
You should be able to try to deploy with a ledger to sepolia with the default Counter contract. Haven't tried this specifically but basically any
|
thanks, I'll give this a try with my ledger |
I am also facing this problem. Any news on if this will be solved? |
For me downgrading to: Here's a reproduction of the issue: https://github.com/bgd-labs/static-a-token-v3/blob/main/scripts/Deploy.s.sol#L152 |
Also seeing this - trying to deploy via https://github.com/collectivexyz/revolution-protocol deploy script in
|
seeing the same after 3/14 txs on Base. |
@mattsse any hunch on what is going wrong? This issue is getting increasingly problematic for us as on tooling we rely on patches from newer foundry versions, but for actual execution of things ppl have to downgrade to a version from early november last year. |
while the issue with compiling --build-info was recently fixed, most ppl are stuck on months old foundry due to foundry-rs/foundry#6516, so reverting the change for now
* feat: multi verification * fix: remove some leftovers * fix: snowscan api url * fix: improve logging * fix: readd --force flag for build info while the issue with compiling --build-info was recently fixed, most ppl are stuck on months old foundry due to foundry-rs/foundry#6516, so reverting the change for now * fix: lint
Starting investigation - ty!! |
I was not able to reproduce this on latest nightly for both @cxkoda @sakulstra @rocketman-21 @sendra @mpeyfuss could you please upgrade to latest nightly and try again? If the issue persists please drop here your setup information so we could test more. Following info would be useful:
|
@klkvr for me it still does not work.
Here's the repro: https://github.com/bgd-labs/v2-stable-debt-offboarding/blob/main/scripts/Deploy.s.sol#L7
and then remain stuck forever (nothing ever showing on my ledger) |
Hi @sakulstra I'm able to reproduce the stalling issue, given your repro. I'm also able to verify that on commit I'm using the following setup:
It appears that if I comment out / remove the external
One thing I noticed is that when running the script a connection is opened to the Ledger, as no other connection is accepted, but it does not request a signature on the screen. @mpeyfuss I'm unable to replicate the same stalling behavior with your example
|
hi @zerosnacks there are definitely external dependencies in the libraries I work with but they are all installed with |
Experiencing this as well with the latest forge on Mac OS 14.4 using a ledger nano x. To reproduce:
Here's the output I get:
Stays there forever. Here's the deploy script: contract DeploySepolia is Script {
IJBDirectory jbDirectory = IJBDirectory(0x3B3Bd16cc76cd53218e00b600bFCa27aA5057794);
IJBOperatorStore jbOperatorStore = IJBOperatorStore(0x8f63C744C0280Ef4b32AF1F821c65E0fd4150ab3);
bytes4 payMetadataDelegateId = bytes4("721P");
bytes4 redeemMetadataDelegateId = bytes4("721R");
JBTiered721DelegateDeployer delegateDeployer;
JBTiered721DelegateProjectDeployer projectDeployer;
JBTiered721DelegateStore store;
function run() external {
IJBDelegatesRegistry registry = IJBDelegatesRegistry(
stdJson.readAddress(
vm.readFile(
"node_modules/@jbx-protocol/juice-delegates-registry/broadcast/Deploy.s.sol/11155111/run-latest.json"
),
".transactions[0].contractAddress"
)
);
// Make a static call for sanity check
assert(registry.deployerOf(address(0)) == address(0));
vm.startBroadcast();
JBTiered721Delegate noGovernance = new JBTiered721Delegate(jbDirectory, jbOperatorStore, payMetadataDelegateId, redeemMetadataDelegateId);
JBTiered721GovernanceDelegate onchainGovernance = new JBTiered721GovernanceDelegate(
jbDirectory,
jbOperatorStore,
payMetadataDelegateId,
redeemMetadataDelegateId
);
delegateDeployer = new JBTiered721DelegateDeployer(onchainGovernance, noGovernance, registry);
store = new JBTiered721DelegateStore();
projectDeployer = new JBTiered721DelegateProjectDeployer(
jbDirectory,
delegateDeployer,
jbOperatorStore
);
console.log("registry ", address(registry));
console.log("project deployer", address(projectDeployer));
console.log("store ", address(store));
}
} |
@filipviz / @mpeyfuss / @sakulstra / @rocketman-21 / @horsefacts / @soloblack / @sendra could you please re-test against the latest Foundry nightly (to update run: It appears that the bug is related to the kb size of the contract suite being deployed. In yesterday's nightly a PR was merged to switch to Alloy's Ledger signer and, from my testing on @sakulstra's and @rocketman-21's repo's, it appears to have been resolved by that: https://github.com/foundry-rs/foundry/releases/tag/nightly-460319558e455611be1de64be8364c65c6896d15 |
I can confirm that I am able to get transactions to show on my ledger, however, now for every chain, the gas price selected is low by a factor of about 1000. Ex: Sepolia gas price right now is around 1 gwei but |
@mpeyfuss today's nightly includes fix for eip-1559 estimation, could you please check if the issue is resolved? |
@klkvr so far so good! |
Component
Forge
Have you ensured that all of these are up to date?
What version of Foundry are you on?
forge 0.2.0 (d4e6b43 2023-12-04T13:39:22.221218000Z)
What command(s) is the bug in?
forge create && forge script
Operating System
macOS (Apple Silicon)
Describe the bug
forge create --ledger
andforge script --ledger --broadcast
does not prompt for tx signature on the ledger. The cli outputs that it's sending the transaction but nothing actually pops up on my ledger. Changing back to version forge 0.2.0 (60ec002 2023-12-04T13:54:02.349674000Z) does not cause this issue and the transactions shows up on my ledger.cast send --ledger
also works great on the latest build.The text was updated successfully, but these errors were encountered: