Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for revert strings #1377

Merged
merged 3 commits into from
Apr 23, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Apr 21, 2022

BLOCKED BY gakonst/ethers-rs#1161

Motivation

Closes #1375

Solution

Add revert_strings config var and argument

@mattsse mattsse added Cmd-forge-build Command: forge build T-feature Type: feature labels Apr 21, 2022
@mattsse mattsse force-pushed the matt/add-revert-strings-option branch from 6cbf68b to 2e5a35e Compare April 21, 2022 17:35
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit, otherwise LGTM!

cli/src/cmd/forge/build.rs Outdated Show resolved Hide resolved
Co-authored-by: Bjerg <onbjerg@users.noreply.github.com>
@mattsse mattsse merged commit 139c073 into foundry-rs:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmd-forge-build Command: forge build T-feature Type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow --revert-strings flag to pass to compiler for forge build
2 participants