Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anvil): deserialize numeric params properly #1857

Merged
merged 2 commits into from Jun 8, 2022
Merged

fix(anvil): deserialize numeric params properly #1857

merged 2 commits into from Jun 8, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jun 7, 2022

Motivation

some serde annotations were wrong, combination of top level sequence + param level deserialize_number is not possible

Solution

use new deserialize_number_seq to match ganache/hardhat numeric arguments: [1], [0x01], 1

@mattsse mattsse added T-bug Type: bug C-anvil Command: anvil labels Jun 7, 2022
gakonst
gakonst approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one

@gakonst gakonst merged commit 60c5470 into foundry-rs:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
C-anvil Command: anvil T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst