Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anvil): only include historic logs if from field set #1861

Merged
merged 1 commit into from Jun 7, 2022
Merged

fix(anvil): only include historic logs if from field set #1861

merged 1 commit into from Jun 7, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jun 7, 2022

Motivation

failing ethers-rs test highlighted an issue with eth_newFilter and historic logs

Solution

  • port ethers-rs test
  • only include historic logs if from_field set

@mattsse mattsse added T-bug Type: bug C-anvil Command: anvil labels Jun 7, 2022
@mattsse mattsse mentioned this pull request Jun 7, 2022
Merged
3 tasks
@gakonst gakonst merged commit 07b3520 into foundry-rs:master Jun 7, 2022
@gakonst gakonst mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
C-anvil Command: anvil T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst