forge(fix): dont give out error if artifact has no source on script

[joshieDo]

Motivation

If the artifact for whatever reason has no source (it should), we don't want to exit, because they're only necessary for the debugger.

Solution

[mattsse]

lgtm, but can we please add a smol note there?

also does this indicate that something's wrong the the artifacts or is this script related?

[joshieDo]

also does this indicate that something's wrong the the artifacts or is this script related?

Given that source_file() returns an Option, I am assuming that there is a situation where artifacts have no source... But I don't know which tbh

We can add a warn! if it doesn't find one?

[gakonst]

Is this related to the guy on Telegram that was getting "source not found"?

This makes sense - but worth us understanding why they got that error in the first place?

[mattsse]

just a hunch but None is only returned if there's no id present in the Configurable artifacts, we only added this ~1-2 weeks ago so perhaps they updated forge build ran with old artifacts

https://github.com/gakonst/ethers-rs/blob/master/ethers-solc/src/artifact_output/configurable.rs#L87

I think should be ok to merge, but let's add a warn! trace to the else branch

[sendra]

Is this related to the guy on Telegram that was getting "source not found"?

This makes sense - but worth us understanding why they got that error in the first place?

The error I got was because the path I was using to get the artifacts was not correct. When changed to use path from project root, it worked fine.