fix: don't use provider gas estimate for optimism #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad-js
changed the title
chad-js
force-pushed
the
optimism-gas-estimate
branch
from
39abc58
to
e1a1f39
Compare
|
just renamed my commit lol realized I named incorrectly |
|
Yep this is perfect, good to merge IMO Thanks @chad-js! |
mattsse
added
C-forge
0xca11
pushed a commit
to 0xca11/foundry
that referenced
this pull request
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context provided here: #2002. This change ensures that gas estimation is not underestimated for Optimism.
Solution
Following the solution to ensure we don't calculate gas differently for Optimism, as explained here by @mds1 and @joshieDo (thanks for the help! 馃槃) #2002 (comment). I am only addressing the first point in this changeset.
To test, successfully ran the same script with the same contract and args as specified in the issue on anvil forks of optimism and optimism kovan. Also successfully ran a separate deploy script that was previously failing on prod optimism.