Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forge): force optimism and arbitrum to --slow mode #2046

Merged
merged 4 commits into from Jun 21, 2022

Conversation

joshieDo
Copy link
Collaborator

Motivation

ref #2002 (comment)

Force --slow on Arbitrum and Optimism. Both of don't have mempools like L1's so if you send multiple txs they get rejected with nonce too low.

Move RPC gas estimation right before sending the intended tx, and add a note to the output indicating the "total gas/ETH cost estimates" shown beforehand aren't guaranteed to be accurate (since we don't estimate Optimism costs correctly)

--
Also removed the first script gas estimation if we have a RPC present, since it doesn't give any valuable information. Some users were also confused by the [expected] discrepancies on both.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmd-forge-script Command: forge script T-perf Type: performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants