Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cast): add signature identifier to cast run #2047

Merged
merged 1 commit into from Jun 21, 2022

Conversation

joshieDo
Copy link
Collaborator

Motivation

cast run is another command which benefits from the signature identifier. I don't think forge test benefits from it, for example.

Solution

before:
image

after:
image

While adding, I noticed another issue. Since the external databases (4byte and sam) do not specify the function outputs, we were getting an empty list of output tokens.

after fix:
image

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse merged commit 8b33ded into foundry-rs:master Jun 21, 2022
@onbjerg onbjerg added the T-feature Type: feature label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants