fix(forge): new error message for vm.addr() when passing invalid private keys #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Jun 29, 2022
| U256::from_str("0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEBAAEDCE6AF48A03BBFD25E8CD0364141") | ||
| .unwrap(); | ||
| if private_key > secp256k1_order { | ||
| return Err("Private key is greater than secp256k1 curve order.".to_string().encode().into()) |
There was a problem hiding this comment.
I suspect most user's won't know what "curve order" means or what that value is. What do you think about:
Suggested change
| return Err("Private key is greater than secp256k1 curve order.".to_string().encode().into()) | |
| return Err("Private key must be less than 115792089237316195423570985008687907852837564279074904382605163141518161494337.".to_string().encode().into()) |
There was a problem hiding this comment.
I agree it is already better but maybe there is a more usable way to print the value
|
By the way does anybody know a dependency that re exports : https://docs.rs/secp256k1/latest/secp256k1/constants/constant.CURVE_ORDER.html It would be the cleanest way to use the dep's constant edit: i think ethers-rs does the job yet again |
gakonst
approved these changes
Jun 30, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2158
I thought about storing the curve order value in another way, like an array of bytes, but i think the marginal perf gain is not worth the less readable code.