feat(fmt): literal expressions #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
L-ignore
rkrasiuk
commented
Jun 30, 2022
|
crazy idea, maybe we can have |
|
@gakonst heh, thought of that as well. agree on address auto check-sum 💯 , but i'd rather leave underscores for when we implement config and make it an option there |
|
SGTM - just dumping thoughts |
onbjerg
added
T-feature
* Make FormatBuffer handle strings The FormatBuffer automatically adds indents after newlines, so it needs to handle string based newlines and be aware that no indent should be added. Therefore the FormatBuffer tracks the state of whether or not its in a string (it also needs to track the state of whether or not its inside of a comment in order to do this) and only adds indents where necessary. Signed-off-by: Julian Popescu <hi@julian.dev>
jpopesculian
force-pushed
the
rkrasiuk/fmt-literal-exprs
branch
from
2da7805
to
c413a54
Compare
gakonst
approved these changes
Jul 6, 2022
Comment on lines
+43
to
+44
| hex"001122FF"; | ||
| hex"00112233" hex"44556677"; |
There was a problem hiding this comment.
maybe for follow up, this removes the _
Rjected
pushed a commit
to Rjected/foundry
that referenced
this pull request
Jul 7, 2022
* literal exprs * remove todo * clippy * addr literal & enum loc fix * Make FormatBuffer handle strings (foundry-rs#2225) * Make FormatBuffer handle strings The FormatBuffer automatically adds indents after newlines, so it needs to handle string based newlines and be aware that no indent should be added. Therefore the FormatBuffer tracks the state of whether or not its in a string (it also needs to track the state of whether or not its inside of a comment in order to do this) and only adds indents where necessary. Signed-off-by: Julian Popescu <hi@julian.dev> * added unicode support Co-authored-by: Julian Popescu <jpopesculian@gmail.com> Co-authored-by: Julian Popescu <hi@julian.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
fmt formatting of:
Expression::BoolLiteralExpression::NumberLiteralExpression::HexNumberLiteralExpression::RationalNumberLiteralExpression::StringLiteralExpression::HexLiteralExpression::AddressLiteral