Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create): use cached artifacts correctly #2202

Merged
merged 3 commits into from
Jul 4, 2022
Merged

fix(create): use cached artifacts correctly #2202

merged 3 commits into from
Jul 4, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jul 4, 2022 •
edited

Blocked by gakonst/ethers-rs#1449

Motivation

  • fixes a bug where cached artifacts where ignored during create

Solution

  • use improved ethers-solc getters
  • add tests against local anvil

@mattsse mattsse added T-bug Type: bug Cmd-forge-create Command: forge create labels Jul 4, 2022
@mattsse mattsse marked this pull request as ready for review July 4, 2022 18:55
@gakonst gakonst merged commit fcf2f31 into foundry-rs:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
Cmd-forge-create Command: forge create T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst