Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(script): save transaction pretty formatted #2217

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jul 5, 2022

Motivation

Closes #2204

Solution

write pretty

@mattsse mattsse added the L-ignore Log: ignore PR in changelog label Jul 5, 2022
@mds1
Copy link
Collaborator

mds1 commented Jul 5, 2022

Can we also save txs using the correct types to facilitate type inference in #2153? For example, gas and nonce should be numbers instead of hex strings, etc.

(Maybe not the correct PR for it, but figured I'd mention it easy in case it's easy. It's also possible this is already complete and I just haven't noticed since I haven't ran a script recently)

@mattsse
Copy link
Member Author

mattsse commented Jul 5, 2022

Can we also save txs using the correct types to facilitate type inference in #2153? For example, gas and nonce should be numbers instead of hex strings, etc.

(Maybe not the correct PR for it, but figured I'd mention it easy in case it's easy. It's also possible this is already complete and I just haven't noticed since I haven't ran a script recently)

I think I'd be better to handle this in the cheatcodes impl, because in there we'd need to do Value -> Abi types anyway, I guess

@mds1
Copy link
Collaborator

mds1 commented Jul 5, 2022

Sounds good, thanks—I'll leave a comment on that issue for reference.

@mattsse mattsse merged commit 1eb6756 into foundry-rs:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-ignore Log: ignore PR in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(forge): scripts should output formatted json to broadcast/
2 participants