fix/perf(forge): improve glob path matching #2480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the
--match-path
argument takes a glob, commonly./test/*
, however the leading current path./
results in mismatches since the matcher is called withtest/Contract.sol
.also the matcher was compiled on every invocation
closes #2477
Solution
./
caseGlobMatcher
type that compiles the glob regex while parsing, so it can be reused efficiently