feat: etch some bytes to empty accounts on mock #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Aug 3, 2022
Comment on lines
+273
to
+274
| .map(|code| code.is_empty()) | ||
| .unwrap_or(true) |
There was a problem hiding this comment.
there's also map_or https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.map_or
but I still prefer unwrap_or just because this is more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It might be preferred in some situations to mock functions on empty accounts instead of deploying a contract just to overwrite all of the calls. This works fine in a lot of cases, but if you mock a function with no return value, Solidity will insert an
extcodesizecheck to make sure the target address has code to run.Functions with no return values are usually mocked if you are mocking a contract that is acted upon by some other contract.
Solution
If the target of
mockCallhas no code we etch a singular 0 byte (STOP)Closes #1987