Fixed fuzz int overflow #2594
Merged
Fixed fuzz int overflow #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome!!! For good measure, can we get a simple int128 test? |
|
merging so it's fixed ASAP and let's do an extra test in follow up @alexeuler ? |
|
Epic thanks for fixing so quick legends! |
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
* fixed fuzz int overflow * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2560
The problem was that generating random int relied on the overflow behavior for U256. I.e. it assumed that bits for U256 are just the bits of I256. This perfectly generates random I256. However it stops working when we generate I128 and use I256 for that. Because U128 is not overflown in I256.