fix(forge): set script verification retries at 5 with a 5 second delay #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
T-bug
joshieDo
changed the title
onbjerg
approved these changes
Aug 12, 2022
cli/src/cmd/forge/script/mod.rs
Outdated
| @@ -549,6 +549,12 @@ impl VerifyBundle { | |||
| config_path: if config_path.exists() { Some(config_path) } else { None }, | |||
| }; | |||
|
|
|||
| // Default from `RetryArgs` struct. | |||
| if retry.delay.is_none() && retry.retries == 1 { | |||
There was a problem hiding this comment.
I think we can just add these defaults directly on RetryArgs if they are more sane defaults for the create-related commands
There was a problem hiding this comment.
+1 on that, let's just bump the Retry defaults instead
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
foundry-rs#2739) * 5 retries with 5s delay for forge script verification * set default on RetryArgs instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Getting quite a few user reports of the verification process failing with:
This usually happens when the indexer is too slow on picking up the contract (looking at you rinkeby...).
ref #2435
Solution
While
Retryargs are available, most users are not aware. And given that we have a lot of flags, it's understandable. Other commands have their own specific defaults forRetry, so I added more reasonable ones toforge script.