Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forge): decode traces when an onchain simulation fails #2875

Merged
merged 3 commits into from Aug 22, 2022

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Aug 22, 2022

Motivation

closes #2865

Solution

Doesn't panic, and decodes traces when an onchain simulation fails. Also, it fails early instead of going through the rest of transactions.

@joshieDo joshieDo marked this pull request as ready for review August 22, 2022 12:30
@joshieDo joshieDo marked this pull request as draft August 22, 2022 12:34
@joshieDo joshieDo marked this pull request as ready for review August 22, 2022 14:18
@mattsse mattsse merged commit b21154d into foundry-rs:master Aug 22, 2022
@mattsse mattsse added the T-bug Type: bug label Aug 22, 2022
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
…s#2875)

* decode err on onchain simulation failures

* change message

* add deployment fail reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No on-chain traces present to help debug failing forge script
2 participants