feat(forge): fmt multiline function header style config

[rkrasiuk]

Motivation

close #3186

Solution

This PR contains breaking change of removing func_attrs_with_params_multiline config option in favor of multiline_func_header style option. This does change the default behavior of the formatter. Keeping as a draft for a discussion

@mds1 @gakonst @transmissions11

[mds1]

From the source:

pub enum MultilineFuncHeaderStyle {
    /// Write function parameters multiline first
    ParamsFirst,
    /// Write function attributes multiline first
    AttributesFirst,
    /// If function params or attrs are multiline
    /// split the rest
    All,
}

So IIUC, ParamsFirst does this:

function computeAddresses(
  address asset
) public view returns (address, address) {

AttributesFirst does this:

function computeAddresses(address asset)
  public
  view
  returns (address, address)
{

But:

1. I'm not sure I understand what All does
2. Does ParamsFirst imply wrapping return params too, like the below? And if so does when are inputs vs. outputs split?

function foo(address asset) public view returns (
  address,
  address,
  address,
  address
) {

[rkrasiuk]

@mds1

1. All means if one is multiline, write the other multiline as well
2. the returns keyword is really treated as modifier considering its location in function definition. the formatter will try to fit return params in one line or split multiline regardless whether modifier are on single line or multiline

[mds1]

Got it, this approach sgtm then!

[transmissions11]

this looks great!

[mattsse]

lgtm,

love the testing we have for fmt