Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(evm, inspector): use GasInspector for Debugger #3261

Merged
merged 3 commits into from
Sep 26, 2022
Merged

refactor(evm, inspector): use GasInspector for Debugger #3261

merged 3 commits into from
Sep 26, 2022

Conversation

shekhirin
Copy link
Contributor

@shekhirin shekhirin commented Sep 18, 2022 •
edited
Loading

Motivation

bluealloy/revm#222

Solution

Gas calculation in debugger works the same as before:
foundry

@shekhirin shekhirin mentioned this pull request Sep 18, 2022
Merged
@rkrasiuk rkrasiuk added T-feature Type: feature A-debugger Area: debugger labels Sep 18, 2022
@gakonst
Copy link
Member

gakonst commented Sep 24, 2022

nice! what are we missing to get this over the line?

mattsse
mattsse reviewed Sep 25, 2022
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

any remaining blockers? revm was also just bumped

@shekhirin shekhirin marked this pull request as ready for review September 26, 2022 12:06
@shekhirin
Copy link
Contributor Author

@gakonst @mattsse I think it's done, wanted to test it a bit more to be sure that behaviour is the same. I believe it's fine.

mattsse
mattsse approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 5342d1c into foundry-rs:master Sep 26, 2022
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
@shekhirin @iFrostizz
refactor(evm, inspector): use GasInspector for Debugger (foundry-rs#3261
fbdc3d9 
)

* refactor(evm, inspector): use GasInspector for Debugger

* calculate used gas before step execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-debugger Area: debugger T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shekhirin @gakonst @mattsse @rkrasiuk