Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cast): use correct description for send #371

Merged
merged 1 commit into from
Jan 5, 2022
Merged

fix(cast): use correct description for send #371

merged 1 commit into from
Jan 5, 2022

Conversation

tlancina
Copy link
Contributor

@tlancina tlancina commented Jan 5, 2022

The CLI description for send is incorrect, it's the docstring for the Wallet struct. You can see this by running cast help send.

I thought #369 introduced the issue, but it seems that there is an open bug in structopt that 0cc47662aab7ba4475996c141b9e1d8e64df84f4 ran into.

This PR implements the workaround from that issue. If this isn't a good solution, it looks like there might also be a way around by using clap directly to override app.about after it's set incorrectly (based on the generated output).

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution is good!

@gakonst gakonst merged commit 000b3b4 into foundry-rs:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants