Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(anvil): make impersonated tx hashes sender unique (#3775)" #3809

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Dec 1, 2022

Motivation

Reverts #3775

Closes #3803

This change was bad since this causes a lot of friction:

  • with this phase keccak(tx) != tx.hash the we use to identify the tx

Instead #3759 should be fixed via #3808 by setting the from field

Solution

revert the previous change until we found a better way, since this change did more harm than good apparently.

@mattsse mattsse added the T-bug Type: bug label Dec 1, 2022
@mattsse mattsse requested a review from rkrasiuk December 1, 2022 21:06
@mattsse mattsse merged commit 33df571 into foundry-rs:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression after commit e471f102b07f6460c9fdf18f018a7e08e85f33f0
2 participants