feat: envWithDefault cheatcode initial implementation #3732 #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Dec 1, 2022
mattsse
reviewed
Dec 1, 2022
evm/src/executor/abi/mod.rs
Outdated
| @@ -41,6 +41,20 @@ ethers::contract::abigen!( | |||
| envBytes32(string,string)(bytes32[]) | |||
| envString(string,string)(string[]) | |||
| envBytes(string,string)(bytes[]) | |||
| envWithDefault(string,bool)(bool) | |||
There was a problem hiding this comment.
I'd like to suggest an alternative name here:
envOr or even variants for all types like envStringOr
imo Default is not really fitting here
There was a problem hiding this comment.
I'm fine with envOr, just originally chose envWithDefault cause it felt more explicit, though envOr is more aligned with rust-like syntax
|
|
|
full send - thanks @slvDev |
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Issue #3732
That is my first PR to Foundry - please correct me if I got anything wrong.
Motivation
As noted by @vicnaum, there is a demand for non-reverting cheatcode for reading from Environment
Solution
Based on @mds1 suggestion: a new cheatcode was created named
vm.envWithDefault(string name, <defaultVal>), where type determines the type and encoding of the Environment Variable