feat(config): allow gas_limit = \"max\" #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Dec 1, 2022
| @@ -120,6 +120,7 @@ block_number = 0 | |||
| fork_block_number = 0 | |||
| chain_id = 1 | |||
| # NOTE due to a toml-rs limitation, this value needs to be a string if the desired gas limit exceeds `i64::MAX` (9223372036854775807) | |||
| # `gas_limit = "Max"` is equivalent to `gas_limit = "18446744073709551615"` | |||
There was a problem hiding this comment.
Should we change the default gas_limit to be the max also? with u64::MAX that seems ok, since you can still run out of gas so there's not really any added "infinite run duration" risk
There was a problem hiding this comment.
let's do that separately as it relates to the "revm unlimited gas" conversation
gakonst
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a "max" alias for
gas_limitSolution