Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(debugger): Large memory usage from trying to draw unseen lines #3814

Merged
merged 2 commits into from
Dec 1, 2022
Merged

fix(debugger): Large memory usage from trying to draw unseen lines #3814

merged 2 commits into from
Dec 1, 2022

Conversation

brockelmore
Copy link
Member

@brockelmore brockelmore commented Dec 1, 2022 •
edited

Motivation

Fix #3805

Solution

Dont try to draw memory lines that aren't visible

@brockelmore brockelmore changed the title Brock/debugger mem fix fix(debugger): Large memory usage from trying to draw unseen lines Dec 1, 2022
@brockelmore
Copy link
Member Author

previous flamegraph (see draw_memory cpu usage):
image

TUI no longer majority of cpu time:
Screen Shot 2022-12-01 at 2 54 51 PM

reduces memory usage and cpu time significantly (cpu time eyeballed went from 40% to 3%)

mattsse
mattsse approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-.-

lgtm, nice catch

@mattsse mattsse added A-debugger Area: debugger T-perf Type: performance labels Dec 1, 2022
@gakonst
Copy link
Member

gakonst commented Dec 1, 2022

Wow

@gakonst gakonst merged commit 4dbb737 into master Dec 1, 2022
@gakonst gakonst deleted the brock/debugger_mem_fix branch December 1, 2022 23:01
@karmacoma-eth
Copy link
Contributor

that was fast! 👏

@brockelmore
Copy link
Member Author

that was fast! 👏

its amazing what a simple reproduction does! Thanks!

@AlexMasmej
Copy link

🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-debugger Area: debugger T-perf Type: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge test --debug hangs on large-ish memory expansion
5 participants
@brockelmore @gakonst @karmacoma-eth @AlexMasmej @mattsse