fix(forge): Fix cheatcodes not cooperating with vm.transact

[AdithyaNarayan]

Motivation

Closes #3797

Solution

• Add optional inspector to commit_transaction
• Add implementation for RollFork3/vm.rollFork(uint256 forkId, bytes32 transaction) (which was not implemented until now for some particular reason?)
• Add tests for transact and rollFork cooperating with cheatcodes

It is evident that the Cheatcodes inspector doesn't inspect the transaction that is executed in transact since not only does vm.recordLogs not work as expected but even other cheatcodes like vm.expectCall doesn't work as expected.
I added an optional inspector to inspect the new EVM instance that the transact is run on. However, since the Cheatcodes inspector needs the Database to also implement the DatabaseExt trait, I create a new Backend database with the fork's database and pass it to the EVM.

Note that, this means that the DatabaseExt trait now depends on Backend which implements DatabaseExt itself. It is a circular dependency. Would this design be prefered or shall I move the responsibility of passing a DatabaseExt all the way up to the caller of transact?

Also, I've noticed that vm.transact doesn't revert when the transaction is supposed to revert, shall I create a separate issue for this?

[mattsse]

thanks for looking into this

Note that, this means that the DatabaseExt trait now depends on Backend which implements DatabaseExt itself. It is a circular dependency.

While this seems to be working, I'm hesitant to move forward with this because this will eventually cause all sorts of problems.

it looks like we only need the Cheatcodes inspector though?

and since the cheatcodes triggers the transact cheatcode call, it'd be perfectly fine to pass this as inspector instead?

[AdithyaNarayan]

Yep, that makes sense! I thought that down the road other inspectors might be needed but didn't realise that it is only being called inside the Cheatcodes inspector. Changed it.

Should this inspector inspect the roll_fork_to_transaction transactions as well? Or only transact?

[mattsse]

Should this inspector inspect the roll_fork_to_transaction transactions as well? Or only transact?

hmm not entirely sure, but I think we can start by adding it to transact only.

[mattsse]

lgtm, tysm