respect silent argument in script command #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-m-aditya
force-pushed
the
i-m-aditya/respect-silent-argument-in-script-command
branch
from
03779e3
to
e1ffba8
Compare
i-m-aditya
force-pushed
the
i-m-aditya/respect-silent-argument-in-script-command
branch
from
e1ffba8
to
d69efd2
Compare
mattsse
reviewed
Jan 24, 2023
i-m-aditya
force-pushed
the
i-m-aditya/respect-silent-argument-in-script-command
branch
4 times, most recently
from
842650b
to
67835b1
Compare
i-m-aditya
force-pushed
the
i-m-aditya/respect-silent-argument-in-script-command
branch
from
67835b1
to
755fed5
Compare
mattsse
requested changes
Jan 26, 2023
cli/src/cmd/forge/script/sequence.rs
Outdated
|
|
||
| println!("\nTransactions saved to: {path}\n"); | ||
| shell::println(format!("\nTransactionsdffs saved to: {path}\n"))?; | ||
| // println!("\nTransactions saved to: {path}\n"); |
There was a problem hiding this comment.
Suggested change
| // println!("\nTransactions saved to: {path}\n"); |
cli/src/cmd/forge/script/cmd.rs
Outdated
Comment on lines
33
to
34
| if self.opts.args.silent { | ||
| shell::set_shell(shell::Shell::from_args(true, false))?; |
There was a problem hiding this comment.
can be combined by using self.opts.args.silent as argument
mattsse
approved these changes
Jan 27, 2023
|
the failing script tests indicate that something's not behaving as expected |
i-m-aditya
force-pushed
the
i-m-aditya/respect-silent-argument-in-script-command
branch
from
c5f80b3
to
09b46eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Respect --silent argument in forge script command
Solution
Fixes #4009