chore: debugger improvements 2 #6494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/debugger-stuff2
branch
2 times, most recently
from
a73c1fc
to
2b21b3a
Compare
mattsse
approved these changes
Dec 1, 2023
Comment on lines
+407
to
+412
| let mut debugger = DebuggerBuilder::new() | ||
| .debug_arena(&result.debug) | ||
| .decoder(&decoder) | ||
| .sources(sources) | ||
| .build()?; | ||
| debugger.try_run()?; |
Comment on lines
+27
to
+31
| /// Creates a new debugger builder. | ||
| #[inline] | ||
| pub fn new() -> Self { | ||
| Self::default() | ||
| } |
There was a problem hiding this comment.
personally, I think new -> default is redundant
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up to #6491
No functional changes, just clean up around terminal init by using RAII.
Bad diff because of moving to new file :(
Solution