native string utils cheatcodes #6891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1010adigupta
requested review from
DaniPopes,
Evalir and
mattsse
as code owners
Evalir
requested changes
Jan 24, 2024
mattsse
requested changes
Jan 24, 2024
|
okay working on tests now |
mds1
reviewed
Jan 24, 2024
crates/cheatcodes/spec/src/vm.rs
Outdated
| @@ -1077,6 +1077,22 @@ interface Vm { | |||
| #[cheatcode(group = String)] | |||
| function parseBool(string calldata stringifiedValue) external pure returns (bool parsedValue); | |||
|
|
|||
| /// Converts the given `string` value to Lowercase. | |||
| #[cheatcode(group = String)] | |||
| function toLowercase(string calldata stringifiedValue) external pure returns (string memory stringifiedValue); | |||
There was a problem hiding this comment.
I tested in forge-std to confirm, and this will error with identifier already declared in solidity since the stringifiedValue name is reused. Suggested var names for all sigs:
Suggested change
| function toLowercase(string calldata stringifiedValue) external pure returns (string memory stringifiedValue); | |
| function toLowercase(string calldata input) external pure returns (string memory output); |
DaniPopes
requested changes
Jan 24, 2024
crates/cheatcodes/spec/src/vm.rs
Outdated
| function trim(string calldata stringifiedValue) external pure returns (string memory stringifiedValue); | ||
| /// Replaces occurrences of `from` in the given `string` with `to`. | ||
| #[cheatcode(group = String)] | ||
| function replace(string calldata stringifiedValue, string calldata from, string calldata to) external pure returns (string memory stringifiedValue); |
There was a problem hiding this comment.
Same as https://github.com/foundry-rs/foundry/pull/6891/files#r1465480622
These are not stringifed values, but just strings, so s or str is more suitable
|
@mds1 ig it's corrected now, can you check |
Evalir
reviewed
Jan 24, 2024
|
@mattsse ig this can be merged now |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #6818
Solution
The following string utils cheatcodes have been created: