Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support offline mode #727

Merged
merged 2 commits into from
Feb 12, 2022
Merged

feat: support offline mode #727

merged 2 commits into from
Feb 12, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Feb 12, 2022

Motivation

Solution

add --offline flag and config option for ethers-rs::solc::Project::offline

@onbjerg onbjerg added the T-feature Type: feature label Feb 12, 2022
gakonst
gakonst approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , passes it up to https://github.com/gakonst/ethers-rs/blob/331caf9418f38646f331a0ee22af4f5725aec77e/ethers-solc/src/resolver.rs#L394

@gakonst gakonst merged commit 9ebcbc2 into foundry-rs:master Feb 12, 2022
@onbjerg onbjerg mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattsse @gakonst @onbjerg