Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anvil): set blob fields in genesis #7853

Merged
merged 3 commits into from
May 3, 2024
Merged

fix(anvil): set blob fields in genesis #7853

merged 3 commits into from
May 3, 2024

Conversation

yash-atreya
Copy link
Collaborator

Motivation

Fixes #7841

Solution

Set blob fields in BlockchainStorage::new() and ClientForkConfig

@yash-atreya yash-atreya self-assigned this May 3, 2024
DaniPopes
DaniPopes approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsse

mattsse
mattsse requested changes May 3, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

smol nit, can we confirm this with a simple test case:

fetch genesis block and check blob fields?

crates/anvil/src/eth/backend/mem/storage.rs Outdated Show resolved Hide resolved
@yash-atreya yash-atreya merged commit fd9ecd8 into foundry-rs:master May 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir Evalir is a code owner

Assignees

@yash-atreya yash-atreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blob fields missing from anvil genesis
3 participants
@yash-atreya @mattsse @DaniPopes